Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channels are duplicated in the domain view #989

Open
cdavernas opened this issue Dec 4, 2024 · 4 comments
Open

Channels are duplicated in the domain view #989

cdavernas opened this issue Dec 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@cdavernas
Copy link

cdavernas commented Dec 4, 2024 •
edited
Loading

I tried this:

I created a channel, to which I added several events

This happened:

When viewing the domain, all events are attached to a dedicated channel instance. Not only is this wrong, to my understanding, but this drastically affects performances.

I expected this:

When viewing the domain, all events should be attached to the SINGLE channel instance they belong to.

Is there a workaround?

No response

Anything else?

No response

EventCatalog Version

No response

Node.js Version

No response

Platform(s)

No response

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@cdavernas cdavernas added the bug Something isn't working label Dec 4, 2024
@boyney123
Copy link
Collaborator

Thanks @cdavernas for raising this.

We are considering adding an option in the eventcatalog.config.js file to decide if you want 1 node per channel, or duplicated nodes. Some folks have shared there might be cases where having it as it is makes sense...

We can have a look in more details, but would this feature switch help you?

For context others have also expressed interest in this https://discord.com/channels/918092420338569216/929038812175278091/1313383813841293362

Side note: We have a feature released yesterday that let's you turn channels on/off, which might help you in the mean time.

@cdavernas
Copy link
Author

cdavernas commented Dec 4, 2024 •
edited
Loading

@boyney123 Thanks for your quick answer!!!

We are considering adding an option in the eventcatalog.config.js file to decide if you want 1 node per channel, or duplicated nodes. Some folks have shared there might be cases where having it as it is makes sense...

Makes absolute sense: a single or duplicated nodes is I guess implementation and/or technology related.

We can have a look in more details, but would this feature switch help you?

Yes, said feature would be an awesome addition, and would definitly do the trick! Maybe that could even be a channel-specific configuration, if that's possible?

@boyney123
Copy link
Collaborator

@boyney123 Thanks for your quick answer!!!

No problem at all 👍

Per channel could be possible yeah, would have to explore more, but I can't see why it wouldnt be... any idea what the property for the channel would be called?

@cdavernas
Copy link
Author

Per channel could be possible yeah, would have to explore more, but I can't see why it wouldnt be... any idea what the property for the channel would be called?

Maybe something like renderMode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boyney123 @cdavernas