Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to be merged with MSRV 1.83 #636

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Changes to be merged with MSRV 1.83 #636

wants to merge 9 commits into from

Conversation

samueltardieu
Copy link
Collaborator

No description provided.

@samueltardieu samueltardieu added the MSRV bump Will be merged later, requires a MSRV bump label Jan 3, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #636 will degrade performances by 33.68%

Comparing msrv-1.83 (0d35cdd) with main (aa33d70)

Summary

❌ 8 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ fill-corner_to_corner_idastar 146.6 µs 221.1 µs -33.68%
❌ corner_to_corner_bfs 1 ms 1.3 ms -19.87%
❌ corner_to_corner_dijkstra 1.4 ms 1.7 ms -18.71%
❌ no_path_astar 1.6 ms 1.8 ms -14.71%
❌ no_path_bfs 1 ms 1.3 ms -23.48%
❌ no_path_dfs 1 ms 1.3 ms -23.6%
❌ no_path_dijkstra 1.4 ms 1.7 ms -15.76%
❌ no_path_fringe 1.6 ms 1.9 ms -14.08%

@samueltardieu samueltardieu force-pushed the msrv-1.83 branch 2 times, most recently from cc60408 to f4b36e4 Compare January 15, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MSRV bump Will be merged later, requires a MSRV bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samueltardieu