Use ugorji codec for unmarshalling key responses in client #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark result: ``` BenchmarkSmallResponseUnmarshal 10000 164524 ns/op BenchmarkManySmallResponseUnmarshal 100 13916636 ns/op BenchmarkMediumResponseUnmarshal 1000 1974295 ns/op BenchmarkLargeResponseUnmarshal 20 80462001 ns/op ok github.com/coreos/etcd/client 7.777s ```
This change speeds up response unmarshal ~2x: ``` BenchmarkSmallResponseUnmarshal 20000 75243 ns/op BenchmarkManySmallResponseUnmarshal 200 6629661 ns/op BenchmarkMediumResponseUnmarshal 1000 1359041 ns/op BenchmarkLargeResponseUnmarshal 20 61600978 ns/op ```
|
Thanks for comparison of ffjson & ugorij - this is really useful. @fgrzadkowski - since you added that codec to the previous client, can you please take a look? |
|
Since @fgrzadkowski is OOO, I think it doesn't make sence to block on him. I looked into it and it LGTM. |
|
@yichengq just checking in on the status here... |
|
Yes - I think it would be great if you could merge it soon - I will be trying to use new etcd client in kubernetes soon. |
|
LGTM |
yichengq
added a commit
that referenced
this pull request
Sep 1, 2015
Use ugorji codec for unmarshalling key responses in client
|
/cc @danmcp - Fast unmarshaling which will also feed through the updated client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change speeds up response unmarshal ~2x:
BEFORE:
AFTER:
Its performance is nearly the same as the one benchmarked in coreos/go-etcd#218. So two packages perform similarly.
@wojtek-t
I have attempted to use ffjson, but it doesn't perform as well as codec. Here is its benchmark:
So I still use codec in etcd/client pkg.
/cc @fgrzadkowski @wojtek-t @timothysc
fixes #3193
ref kubernetes/kubernetes#11962