Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpc-gateway from v1 to v2 #16595

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Upgrade grpc-gateway from v1 to v2 #16595

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
522b698
upgrade grpc-gateway from v1 to v2
fuweid Sep 13, 2023
4ec581a
re-generate all the *.pb.gw.go files
ahrtr Sep 13, 2023
189f709
Apply patches on the generated *.pb.gw.go files to convert v1 message…
ahrtr Sep 13, 2023
de41d4d
dependency: set github.com/grpc-ecosystem/grpc-gateway/v2 version to …
ahrtr Sep 13, 2023
5444cda
remove all usage of v1 grpc-gateway
ahrtr Sep 13, 2023
d06cdfa
Updated the tools/proto-annotation to exclude grpc.gateway package
ahrtr Sep 14, 2023
8eba295
Resolve review comments: add some comments to clarify some confusion …
ahrtr Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated the tools/proto-annotation to exclude grpc.gateway package 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
  • Loading branch information
@ahrtr
ahrtr committed Sep 18, 2023
commit d06cdfa1ee7bbfc1f0ed5a6b6596fc224d2d6e53
9 changes: 8 additions & 1 deletion tools/proto-annotations/cmd/etcd_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,15 @@ import (

var (
// externalPackages that are not expected to have etcd version annotation.
externalPackages = []string{"io.prometheus.client", "grpc.binarylog.v1", "google.protobuf", "google.rpc", "google.api", "raftpb",
externalPackages = []string{
"io.prometheus.client",
"grpc.binarylog.v1",
"google.protobuf",
"google.rpc",
"google.api",
"raftpb",
"grpc.gateway.protoc_gen_swagger.options",
"grpc.gateway.protoc_gen_openapiv2.options",
}
)

Expand Down