Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use fast unmarshalJson code in etcd/client #3193

Closed
yichengq opened this issue Jul 29, 2015 · 3 comments · Fixed by #3308
Closed

use fast unmarshalJson code in etcd/client #3193

yichengq opened this issue Jul 29, 2015 · 3 comments · Fixed by #3308
Assignees
@yichengq
Labels
area/clientv3

Comments

@yichengq
Copy link
Contributor

from coreos/go-etcd#218

ugorji codec is a preferred choice.

It is critical for latency requirement in k8s scenario. We plan to let k8s use etcd/client instead of go-etcd, so this needs to be improved.

/cc @fgrzadkowski @bcwaldon
@yichengq yichengq mentioned this issue Jul 30, 2015
Closed
@wojtek-t
Copy link
Contributor

/subscribe

@wojtek-t
Copy link
Contributor

We should reevalute if ugorij code is still the best. We've seen in some place that ffjson can now be faster. We should reevaluate it and use the better one.

@timothysc
Copy link

cc @eparis probably want to cc Jan

@yichengq yichengq mentioned this issue Aug 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yichengq yichengq

Labels
area/clientv3
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ugorji codec for unmarshalling key responses in client yichengq/etcd
3 participants
@timothysc @yichengq @wojtek-t