Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modbus Controller] Added on_online and on_offline automation #7417

Merged
merged 10 commits into from
Nov 12, 2024
Merged

[Modbus Controller] Added on_online and on_offline automation #7417

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f9987f8
[Modbus Controller] Added `on_online` and `on_offline` automation to …
0x3333 Sep 6, 2024
97d5b92
[Modbus Controller] Fix yaml format.
0x3333 Sep 6, 2024
9d92039
[Modbus Controller] Fix format and slave->server naming.
0x3333 Sep 6, 2024
d0feea8
[Modbus Controller] Fix tests.
0x3333 Sep 6, 2024
dff738d
[Modbus Controller] Fix add callback method.
0x3333 Sep 10, 2024
e6cbb03
Merge remote-tracking branch 'upstream/dev' into modbus_events
0x3333 Sep 10, 2024
3350baf
Merge remote-tracking branch 'upstream/dev' into modbus_events
0x3333 Sep 11, 2024
06e65a0
[Modbus Controller] Fix code generation that was using incorrect int …
0x3333 Sep 12, 2024
5dad0de
Merge remote-tracking branch 'upstream/dev' into modbus_events
0x3333 Sep 13, 2024
0d088cf
Merge branch 'dev' into modbus_events
0x3333 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Modbus Controller] Fix code generation that was using incorrect int … 
…type and failing in some tests.
  • Loading branch information
@0x3333
0x3333 committed Sep 12, 2024
commit 06e65a0747539f2e00768393f71085ff39a2e840
6 changes: 3 additions & 3 deletions esphome/components/modbus_controller/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,17 +302,17 @@ async def to_code(config):
for conf in config.get(CONF_ON_COMMAND_SENT, []):
trigger = cg.new_Pvariable(conf[CONF_TRIGGER_ID], var)
await automation.build_automation(
trigger, [(int, "function_code"), (int, "address")], conf
trigger, [(cg.int_, "function_code"), (cg.int_, "address")], conf
)
for conf in config.get(CONF_ON_ONLINE, []):
trigger = cg.new_Pvariable(conf[CONF_TRIGGER_ID], var)
await automation.build_automation(
trigger, [(int, "function_code"), (int, "address")], conf
trigger, [(cg.int_, "function_code"), (cg.int_, "address")], conf
)
for conf in config.get(CONF_ON_OFFLINE, []):
trigger = cg.new_Pvariable(conf[CONF_TRIGGER_ID], var)
await automation.build_automation(
trigger, [(int, "function_code"), (int, "address")], conf
trigger, [(cg.int_, "function_code"), (cg.int_, "address")], conf
)


Expand Down