Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: support bigint and dynamic import #415

Merged
merged 6 commits into from
Aug 14, 2019
Merged

Update: support bigint and dynamic import #415

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cbe5ed5
fix a failing test with acorn 6.2.0
mysticatea Jul 13, 2019
288d101
update acorn
mysticatea Jul 13, 2019
abd8541
fix CI failure
mysticatea Jul 13, 2019
ae4d815
update eslint-visitor-keys
mysticatea Jul 13, 2019
85a2fe8
Upgrade: acorn@^7.0.0, eslint-visitor-keys@^1.1.0
platinumazure Aug 13, 2019
8d22189
Chore: Fix invalid-new-import fixture index/column
platinumazure Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix CI failure
  • Loading branch information
@mysticatea
mysticatea committed Jul 13, 2019
commit abd8541416d53c6a235bb71cbb5799f28cac63aa
6 changes: 5 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
language: node_js
sudo: false
node_js:
- 6
- 7
Expand All @@ -8,5 +7,10 @@ node_js:
- 10
- 11
- 12

script:
- if [ $TRAVIS_NODE_VERSION -ge 8 ]; then node Makefile.js lint; fi
- node Makefile.js test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity: this was added since eslint v6 don't support node <8?

we may consider dropping node <8, as it has been EOL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aladdin-add I assume that was the case (but hopefully @mysticatea can confirm). I think it makes sense to release a minor version of espree with this functionality if we can, and then we could do a major release to drop Node <8.


after_success:
- npm run coveralls