Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: search result handling with better event listener cleanup #677

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

similar to eslint/eslint#19252

Related Issues

Is there anything you'd like reviewers to focus on?

Ensure that the existing functionality remains unaffected

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/67631baf03d53c00084d010b
😎 Deploy Preview https://deploy-preview-677--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/67631baff0237a0008888b24
😎 Deploy Preview https://deploy-preview-677--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/67631bafa76c19000865e710
😎 Deploy Preview https://deploy-preview-677--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/67631baf77c3d30008ee4256
😎 Deploy Preview https://deploy-preview-677--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/67631baf81aedc00081036cc
😎 Deploy Preview https://deploy-preview-677--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/67631bafe8581e000828f206
😎 Deploy Preview https://deploy-preview-677--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/67631baf03d53c00084d0110
😎 Deploy Preview https://deploy-preview-677--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 785addc
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/67631baf13e1e20008f89970
😎 Deploy Preview https://deploy-preview-677--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@amareshsm amareshsm merged commit 265a53e into main Dec 21, 2024
37 checks passed
@amareshsm amareshsm deleted the refactor-search-results branch December 21, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants