Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Update shouldUseFlatConfig and CLI so flat config is default #17748

Merged
merged 13 commits into from
Dec 20, 2023
Merged

feat!: Update shouldUseFlatConfig and CLI so flat config is default #17748

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d0dea8f
feat!: Update shouldUseFlatConfig so flat config is default
nzakas Nov 10, 2023
df69890
Fix tests
nzakas Nov 10, 2023
208d2bc
Update CLI
nzakas Nov 10, 2023
99e5f75
Fix test
nzakas Nov 10, 2023
8ac03fa
Fix tests
nzakas Nov 13, 2023
728b4bc
Fix lint warning
nzakas Nov 13, 2023
7b359b0
Update bin tests to search for eslint.config.js
nzakas Nov 27, 2023
4fc794c
Update tests/lib/cli.js
nzakas Nov 27, 2023
bbf0119
Update tests/lib/cli.js
nzakas Nov 27, 2023
8b30806
Update tests/lib/cli.js
nzakas Nov 27, 2023
265105f
Merge tests for deprecation warnings
nzakas Nov 27, 2023
35ccf30
Update lib/cli.js
nzakas Dec 8, 2023
4816e25
Update tests/lib/cli.js
nzakas Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update tests/lib/cli.js 
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
  • Loading branch information
@nzakas @mdjermanovic
nzakas and mdjermanovic committed Dec 20, 2023
commit 4fc794c45e676b1f46548834ab783a5905acc2c1
2 changes: 1 addition & 1 deletion tests/lib/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ describe("cli", () => {
describe("when given an invalid built-in formatter name", () => {
it(`should execute with error: with configType:${configType}`, async () => {
const filePath = getFixturePath("passing.js");
const exit = await cli.execute(`-f fakeformatter ${filePath} ${flag}`, null, configType === "flat");
const exit = await cli.execute(`-f fakeformatter ${filePath} ${flag}`, null, useFlatConfig);

assert.strictEqual(exit, 2);
});
Expand Down