Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-unused-vars ignoreRestSiblings check assignments (fixes #14163) #14264

Merged
merged 3 commits into from
Apr 3, 2021
Merged

Fix: no-unused-vars ignoreRestSiblings check assignments (fixes #14163) #14264

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a59207f
Fix: Check assignment reference in no-unused-vars (fixes #14163)
yeonjuan Mar 28, 2021
55f9607
rename variables
yeonjuan Apr 1, 2021
e556f51
add example
yeonjuan Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename variables
  • Loading branch information
@yeonjuan
yeonjuan committed Apr 1, 2021
commit 55f96076370137e0be24b49bfa982f870605b845
6 changes: 3 additions & 3 deletions lib/rules/no-unused-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,10 @@ module.exports = {
*/
function hasRestSpreadSibling(variable) {
if (config.ignoreRestSiblings) {
const hasRestSiblingDef = variable.defs.some(def => hasRestSibling(def.name.parent));
const hasRestSiblingRef = variable.references.some(ref => hasRestSibling(ref.identifier.parent));
const hasRestSiblingDefinition = variable.defs.some(def => hasRestSibling(def.name.parent));
const hasRestSiblingReference = variable.references.some(ref => hasRestSibling(ref.identifier.parent));

return hasRestSiblingDef || hasRestSiblingRef;
return hasRestSiblingDefinition || hasRestSiblingReference;
}

return false;
Expand Down