Skip to content

Change Request: Remove LintMessage#nodeType and TestCaseError#typeΒ #19029

Open
@fasttime

Description

ESLint version

v10.0.0

What problem do you want to solve?

In #18485 (comment) it was agreed to deprecate the nodeType property on LintMessage and remove it in a future release (since that will be breaking change).

LintMessage#nodeType and TestCaseError#type have been deprecated in #19019, so we should probably remove these two properties in v10.

This change will have the most visible impact on the unit tests in eslint, where the deprecated properties are still found in a number of occurrences and will need to be removed, especially TestCaseError#type in rule tests.

What do you think is the correct solution?

Remove LintMessage#nodeType and TestCaseError#type in ESLint v10.

  • Remove the properties and update the logic if necessary
  • Update type definitions
  • Update unit tests
  • Test the changes with other packages, especially @eslint/markdown and @eslint/json to ensure that they will still work
  • Note the breaking changes for plugin developers in the migration guide

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

Metadata

Assignees

No one assigned

    Labels

    acceptedThere is consensus among the team that this change meets the criteria for inclusionbreakingThis change is backwards-incompatiblecoreRelates to ESLint's core APIs and featuresenhancementThis change enhances an existing feature of ESLint

    Type

    No type

    Projects

    • Status

      Blocked

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions