Introduce scheduler pollset for nif select #9275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garazdawi
force-pushed
the
lukas/erts/enif_scheduler_pollset
branch
from
9cc5222 to
c440365
Compare
CT Test Results 3 files 143 suites 48m 58s ⏱️ Results for commit 157d350. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Would the main impact on this inside OTP be related to the file API and socket NIFs? Are there any other parts that would use the separate pollset? |
The primary user is the socket nifs, but also the shell uses it :) File does not use select (as far as I know), so will not be effected. |
garazdawi
force-pushed
the
lukas/erts/enif_scheduler_pollset
branch
2 times, most recently
from
89fc8b6 to
0a3cb7f
Compare
garazdawi
force-pushed
the
lukas/erts/enif_scheduler_pollset
branch
from
0a3cb7f to
7dfda88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FD polling on unix was migrated to a separate thread in OTP-21, polling on FDs that exhibit an "active true" behaviour for drivers were placed in a separate scheduler pollset in order to reduce the number of modifications of the pollset and thus reduce CPU cost. This PR introduces the same mechanism for FDs selected on by nifs.