internal/graphicscommand: clear uniform variables explicitly

This change is a performance optimization. (*uint32sBuffer).alloc doesn't clear the uniform values. Without clearing the values explicitly, CanMergeWithDrawTrianglesCommand might return false even though two commands can be merged.
ericls · Aug 19, 2023 · fcec771 · fcec771
1 parent a9d9143
commit fcec771
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/internal/graphicscommand/command.go b/internal/graphicscommand/command.go
@@ -675,21 +675,33 @@ func (q *commandQueue) prependPreservedUniforms(uniforms []uint32, shader *Shade
 		w, h := srcs[0].InternalSize()
 		uniforms[2] = math.Float32bits(float32(w))
 		uniforms[3] = math.Float32bits(float32(h))
+	} else {
+		uniforms[2] = 0
+		uniforms[3] = 0
 	}
 	if srcs[1] != nil {
 		w, h := srcs[1].InternalSize()
 		uniforms[4] = math.Float32bits(float32(w))
 		uniforms[5] = math.Float32bits(float32(h))
+	} else {
+		uniforms[4] = 0
+		uniforms[5] = 0
 	}
 	if srcs[2] != nil {
 		w, h := srcs[2].InternalSize()
 		uniforms[6] = math.Float32bits(float32(w))
 		uniforms[7] = math.Float32bits(float32(h))
+	} else {
+		uniforms[6] = 0
+		uniforms[7] = 0
 	}
 	if srcs[3] != nil {
 		w, h := srcs[3].InternalSize()
 		uniforms[8] = math.Float32bits(float32(w))
 		uniforms[9] = math.Float32bits(float32(h))
+	} else {
+		uniforms[8] = 0
+		uniforms[9] = 0
 	}
 
 	if shader.unit() == shaderir.Texels {