chore: include invalid data in pump model plot #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olelod
reviewed
Apr 12, 2024
| PumpFlag.INVALID_REQUIRED_HEAD_ABOVE_ACTUAL_HEAD.value, | ||
| pump_flags, | ||
| ) | ||
|
|
There was a problem hiding this comment.
PumpModelResults inherits is_valid from EnergyFunctionResult and is basically is_valid = False when values are nan. I guess you need a new is_valid property on PumpModelResult using the pump_flags you have defined?
There was a problem hiding this comment.
Agree, that is probably what we need.
frodehk
force-pushed
the
ECALC-799-include-invalid-data-pump-model-plot
branch
from
e3880d0 to
078ffb4
Compare
ECALC-799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECALC-799
Why is this pull request needed?
The lower-level results plots currently differ between ‘compressors’ and ‘pumps’. The heading on both power plots state that invalid points are included, however, that is only true for compressors. Pump model plots should also include invalid points.
Issues related to this change:
https://equinor-ecalc.atlassian.net/browse/ECALC-799?atlOrigin=eyJpIjoiYzY1YzExNWJkZTcwNDk2Nzk2MGJmODJmZGVhYTk5OTUiLCJwIjoiaiJ9