Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle inconsistent in LRSH #224

Open
achaikou opened this issue Dec 19, 2019 · 1 comment
Open

Handle inconsistent in LRSH #224

achaikou opened this issue Dec 19, 2019 · 1 comment

Comments

@achaikou
Copy link
Contributor

Implement TODO in dlis_index_records
"handle situation where explicit bits are not the same for every segment"

Usecase:
File contains many LFs.
Last fdata in LF is not complete (expects successor).
Then FILE-HEADER follows, but it is assumed to be the part of the previous record (relevant to #222 as we do not check predecessor).
'Explicit' marker is overwritten to be as in the last record segment. So the fdata + fileheader were considered to be one "explicit" record.
Then find_fileheaders searches explicit records of type 0 (FHLR is 0), but because FDATA is also 0, 'combined' record was assumed to be the start of a new LF.

Which then caused issues while parsing the record as explicit, and debugging was not straightforward.

@ErlendHaa ErlendHaa changed the title Handle inconsistent explicit bits for every LR segment Handle inconsistent in LRSH Nov 24, 2020
@ErlendHaa
Copy link
Contributor

ErlendHaa commented Nov 24, 2020

The example (use case) is resolved by #296, but we still need consistency checking of LRSH attributes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants