Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move JS to author #512

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Move JS to author #512

merged 1 commit into from
Aug 23, 2024

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Aug 23, 2024

Based on contributions to issues (#427, #483), PRs (#482), and review (#501). @jessalynnsebastian happy with this?

@seabbs seabbs added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 8651a9c Aug 23, 2024
9 checks passed
@seabbs seabbs deleted the js-to-aut branch August 23, 2024 09:59
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7acfa8d is merged into main:

  • ✔️day_of_week_model: 36.4s -> 35.8s [-5.31%, +1.74%]
  • ✔️latent_renewal_model: 30.9s -> 27.7s [-29.21%, +8.13%]
  • ✔️missingness_model: 1.29m -> 1.29m [-4.17%, +3.6%]
  • ✔️multi_group_latent_renewal_model: 56s -> 55.5s [-7.97%, +6.25%]
  • ✔️preprocessing: 513ms -> 498ms [-7.83%, +2.02%]
  • ❗🐌simple_model: 4.02s -> 4.37s [+0.98%, +16.83%]
  • ✔️simple_negbin_model_with_pp: 4.38s -> 4.36s [-8.15%, +7.16%]
    These benchmarks are based on package examples which are available here. Further explanation regarding interpretation and methodology can be found in the documentation of touchstone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants