Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enw_aggregate_cumulative drops case counts #427

Open
adrian-lison opened this issue Jan 6, 2024 · 4 comments
Open

enw_aggregate_cumulative drops case counts #427

adrian-lison opened this issue Jan 6, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@adrian-lison
Copy link
Collaborator

adrian-lison commented Jan 6, 2024 •
edited
Loading

Describe the bug
I am not 100% sure if this is a feature or a bug, but I noticed that enw_aggregate_cumulative drops many of the counts in confirmed (as I understand, all which are not part of a complete timestep). This is quite counterintuitive to me, and either needs much clearer explanation in the documentation, or it's a bug.

To Reproduce
I added a test for keeping all counts in branch issue427.
@adrian-lison adrian-lison added bug Something isn't working documentation Improvements or additions to documentation labels Jan 6, 2024
@seabbs
Copy link
Collaborator

seabbs commented Apr 9, 2024

So I think this is a feature but can see why it wouldn't be clear. Any suggested changes for docs or suggestions for other implementations that don't do this?

@seabbs seabbs added enhancement New feature or request and removed bug Something isn't working labels Apr 9, 2024
@seabbs
Copy link
Collaborator

seabbs commented Jul 31, 2024

Any updated views on this @adrian-lison?

@seabbs seabbs mentioned this issue Aug 23, 2024
Merged
@seabbs
Copy link
Collaborator

seabbs commented Aug 23, 2024

I think this is actually a bug based on what @jessalynnsebastian has been finding. JS I think you have a clearer handle on it so perhaps you could summarise/post a reprex/

@seabbs seabbs mentioned this issue Aug 23, 2024
Open
@seabbs
Copy link
Collaborator

seabbs commented Aug 23, 2024

Ah @jessalynnsebastian beat me to it. Does this (#511) look like the issue @adrian-lison?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
epinowcast 0.4.0
Status: No status
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue427 epinowcast/epinowcast
2 participants
@adrian-lison @seabbs