Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full package linting to main in addition to changed files linting on PRs #383

Open
seabbs opened this issue Nov 20, 2023 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@seabbs
Copy link
Collaborator

seabbs commented Nov 20, 2023

Is your feature request related to a problem? Please describe.
Sometimes (i.e. #378) linting issues get through to main or the linters themselves are updated. It would be great to have automated lining of the full package on main both on a schedule and also on a push just so we can be sure that main is always passing all lining checks (or that we know if it is not). This would be in addition to our current listing of just changed files.

Describe the solution you'd like
Either the addition of flexibility to our current GitHub Acton or a new GitHub action (based on the basic usethis template) that triggers on main when new code is added and that runs on a weekly schedule and that lints the entire package (rather than just changed code). Unlike our current workflow this should not trigger on PRs.

Describe alternatives you've considered
Being told this is a bad idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant