Use storage id in data access audit in api #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinPavel
requested changes
Apr 10, 2023
| @@ -434,7 +435,7 @@ public DataStorageDownloadFileUrl generateDataStorageItemUploadUrl(String bucket | |||
| return generatePresignedUrl(client, expires, ownerTag, DEFAULT_CANNED_ACL.toString(), request); | |||
| } | |||
|
|
|||
| public DataStorageFile createFile(String bucket, String path, byte[] contents, String owner) | |||
| public DataStorageFile createFile(S3bucketDataStorage bucket, String path, byte[] contents, String owner) | |||
There was a problem hiding this comment.
let's set all params final in methods that are changed by this PR
tcibinan
added a commit
that referenced
this pull request
May 8, 2023
tcibinan
added a commit
that referenced
this pull request
May 9, 2023
* Add storage id to audit logs in API * Add storage id to SystemLog API * Add storage id to log4j configuration * Repair tests * Add storage id to security indices template * Use keyword type for storage id mapping * Add final keywords to all updated method signatures
tcibinan
added a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #3187.
The pull request adds storage id field to data access audit records in api.