Gui custom capabilities testcases #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryvictol
added
sys/docs
NShaforostov
reviewed
Nov 8, 2021
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2234.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2295.md
Outdated
Show resolved
Hide resolved
docs/testcases/UI/Run_tools_in_sandbox/Launch_parameters/2295.md
Outdated
Show resolved
Hide resolved
NShaforostov
approved these changes
Nov 15, 2021
kamyshova
requested changes
Nov 15, 2021
| "MY_NUMBER_PARAM": 2 | ||
| } | ||
| } | ||
| } |
| "echo 'testLine2' >> ~/testFile1.txt" | ||
| ] | ||
| } | ||
| } |
Comment on lines
51
to
52
| private static final String CUSTOM_CAPABILITIES_1_JSON = "/customCapabilities1.json"; | ||
| private static final String CUSTOM_CAPABILITIES_2_JSON = "/customCapabilities2.json"; |
There was a problem hiding this comment.
Let's move constants over instance variables
https://www.oracle.com/java/technologies/javase/codeconventions-fileorganization.html
| public String getPreference(String preference) { | ||
| searchPreference(preference); | ||
| String[] strings = context().$(byClassName("CodeMirror-code")) | ||
| .findAll(byClassName("CodeMirror-line")).texts().toArray(new String[0]); |
There was a problem hiding this comment.
Why should we result in String[] instead of List?
| searchPreference(preference); | ||
| String[] strings = context().$(byClassName("CodeMirror-code")) | ||
| .findAll(byClassName("CodeMirror-line")).texts().toArray(new String[0]); | ||
| return String.join("\n", strings); |
There was a problem hiding this comment.
What if strings are empty or contain just one value? We should check it before joining with \n
Comment on lines
1190
to
1192
| for (int i = 0; i < 100; i++) { | ||
| actions().sendKeys(Keys.DELETE).perform(); | ||
| } |
| @AfterClass(alwaysRun = true) | ||
| public void fallBackToDefaultToolSettings() { | ||
| logoutIfNeeded(); | ||
| loginAs(admin); | ||
| open(C.ROOT_ADDRESS); |
There was a problem hiding this comment.
Should we open the root address twice (we already open it in loginAs())?
| .launch(this) | ||
| .showLog(getLastRunId()) | ||
| .expandTab(PARAMETERS) | ||
| .ensure(configurationParameter(format("CP_CAP_CUSTOM_%s", custCapability1), "true"), exist) |
There was a problem hiding this comment.
"CP_CAP_CUSTOM_%s" can be constant
| .waitForSshLink() | ||
| .click(taskWithName("Console")) | ||
| .waitForLog("start.sh") | ||
| .ensure(log(), matchText(format("Running '%s' commands:", custCapability1))) |
There was a problem hiding this comment.
"Running '%s' commands:" can be constant
Signed-off-by: kamyshova <yulia_kamyshova@epam.com>
kamyshova
approved these changes
Nov 22, 2021
This was referenced Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides tests for "Custom" capabilities implementation #2234 and #2295