Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HCS images] Ability to preview "global" image of the well #2534

Open
NShaforostov opened this issue Feb 25, 2022 · 3 comments
Open

[HCS images] Ability to preview "global" image of the well #2534

NShaforostov opened this issue Feb 25, 2022 · 3 comments
Assignees
@rodichenko @AleksandrGorodetskii
Labels
goal/charlie 🐟 kind/enhancement New feature or request state/has-case Issues that have test-cases sys/gui Issues related to the web gui

Comments

@NShaforostov
Copy link
Collaborator

Background

Once the #2489 is implemented, users can preview HCS images selecting plate, well, field, etc. to view.
Also, the can switch between separate well fields using simplify well scheme at the right side of the preview pop-up.
But in some cases, it would be convenient to view the global image of the whole well - received by combining of all fields' images of the current well.
We shall add such ability.

Approach

Add a new button near the Show attributes button, e.g.:
image

By click this button:

  • instead of the current selected well's field image the "global" well image shall appear - i.e. all fields images of the current well shall be compiled into one large image - based on the same grid as shown at the "Well" panel at the right side
  • "Settings" panel shall become disabled
  • Well view button should be hidden
  • at the "Well" panel, all available fields shall be highlighted (by orange)
    image

Any cell of such grid should be clickable - by click a cell:

  • the corresponding field image should be opened
  • "Settings" panel shall become enabled
  • Well view button should appear
  • at the "Well" panel, only selected field shall be highlighted by orange

Other options

  • "Well view" shall not be the default view, i.e. if the user selects another well, for example, or plate - the only one field from the well shall be opened (current behavior)
  • Possible, there shall be the ability to switch between "Well" and "Field" views by certain zooming level (by mouse wheel) - TBD
@NShaforostov NShaforostov added kind/enhancement New feature or request sys/gui Issues related to the web gui goal/charlie 🐟 labels Feb 25, 2022
AleksandrGorodetskii added a commit that referenced this issue Mar 11, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): Ability to preview global well image
e96f854
AleksandrGorodetskii added a commit that referenced this issue Mar 11, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): Ability to preview global well image
2b9b956
AleksandrGorodetskii added a commit that referenced this issue Mar 11, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): Move 'Well view' button to right corner contr…
e9c2518 
…ols. Well view now persists between well switching
AleksandrGorodetskii added a commit that referenced this issue Mar 11, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): minor style adjustments
6eff4b8
AleksandrGorodetskii added a commit that referenced this issue Mar 11, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): configuration panel - change 'well view' butt…
44884d4 
…on to button group
rodichenko pushed a commit that referenced this issue Mar 11, 2022
@AleksandrGorodetskii @rodichenko
GUI HCS Viewer (#2534): Ability to preview global well image
1165d69
rodichenko added a commit that referenced this issue Mar 11, 2022
@rodichenko
[HCS images] Ability to preview "global" image of the well (#2534) - …
d7c2c2b 
…displaying global image grid
rodichenko added a commit that referenced this issue Mar 14, 2022
@rodichenko
[HCS images] Ability to preview "global" image of the well (#2534) - …
be6d7f1 
…selecting field
rodichenko pushed a commit that referenced this issue Mar 14, 2022
@AleksandrGorodetskii @rodichenko
GUI HCS Viewer (#2534): Ability to preview global well image
7642ecd 
GUI HCS Viewer (#2534): Move 'Well view' button to right corner controls. Well view now persists between well switching

GUI HCS Viewer (#2534): minor style adjustments

GUI HCS Viewer (#2534): configuration panel - change 'well view' button to button group

GUI HCS Viewer (#2534): Ability to preview global well image

[HCS images] Ability to preview "global" image of the well (#2534) - displaying global image grid

[HCS images] Ability to preview "global" image of the well (#2534) - selecting field
@rodichenko
Copy link
Contributor

@AleksandrGorodetskii, could you please take care of:

  1. [BUG] unable to select previously chosen field of the well

Steps to reproduce:

  • Open any *.hcs image
  • Select any well
  • Select any field (A) of the well
  • Enable global image view for the well
  • Select field (A) from step 3

Expected result: field A selected.
Actual result: nothing happened.

  1. [ENHANCEMENT] Enable global image view by default when selecting a well

AleksandrGorodetskii added a commit that referenced this issue Mar 15, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): unable to select previously chosen field - bu…
63c0856 
…gfix
Merged
AleksandrGorodetskii added a commit that referenced this issue Mar 15, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): enable well view by default when switching be…
97f461c 
…tween wells - enhancement
rodichenko added a commit that referenced this issue Mar 15, 2022
@rodichenko
[HCS images] Ability to preview "global" image of the well (#2534) - …
780217c 
…refactoring
rodichenko added a commit that referenced this issue Mar 15, 2022
@AleksandrGorodetskii @rodichenko
GUI HCS Viewer (#2534) Bugfixes and enhancements (#2557)
2b784dc 
* GUI HCS Viewer (#2534): unable to select previously chosen field - bugfix

* GUI HCS Viewer (#2534): enable well view by default when switching between wells - enhancement

* [HCS images] Ability to preview "global" image of the well (#2534) - refactoring

Co-authored-by: Mikhail Rodichenko <Mikhail_Rodichenko@epam.com>
@rodichenko
Copy link
Contributor

@AleksandrGorodetskii, could you please take care of:

  1. [BUG] unable to select previously chosen field of the well

  2. [ENHANCEMENT] Enable global image view by default when selecting a well

implemented/fixed by #2557

AleksandrGorodetskii added a commit that referenced this issue Mar 16, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): set HcsCellSelector canvas container actual w…
164a2ae 
…idth when vertical scrollbar appears after mounting
AleksandrGorodetskii added a commit that referenced this issue Mar 16, 2022
@AleksandrGorodetskii
GUI HCS Viewer (#2534): set HcsCellSelector canvas container actual w…
6b88641 
…idth when vertical scrollbar appears after mounting
@maryvictol
Copy link
Collaborator

Test case was created by #2786 and located here.

@maryvictol maryvictol added the state/has-case Issues that have test-cases label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodichenko rodichenko

@AleksandrGorodetskii AleksandrGorodetskii

Labels
goal/charlie 🐟 kind/enhancement New feature or request state/has-case Issues that have test-cases sys/gui Issues related to the web gui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rodichenko @AleksandrGorodetskii @NShaforostov @maryvictol