Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the data storage mount script to use the pipe storage mount command in GCP #1371

Open
sidoruka opened this issue Sep 8, 2020 · 0 comments
Open

Update the data storage mount script to use the pipe storage mount command in GCP #1371

sidoruka opened this issue Sep 8, 2020 · 0 comments
Assignees
@mzueva @tcibinan
Labels
goal/dorado ✨ kind/enhancement New feature or request state/verify Issues that are already addressed and require validation sys/cli Issues related to the pipe cli sys/core Issues related to core functionality (API, VM management, ...)
Milestone
v0.17

Comments

@sidoruka
Copy link
Contributor

sidoruka commented Sep 8, 2020

Once the #1187 is merged we'll need to include the pipe storage mount into the job init scripts instead of the gcsfuse

cloud-pipeline/workflows/pipe-common/scripts/mount_storage.py

Line 468 in f8a9088

return 'nohup gcsfuse --foreground -o {permissions} -o allow_other --key-file {credentials} --temp-dir {tmp_dir} ' \

This shall be made optional via SYSTEM PARAMETERS. There is already a parameter for that, which is used for AWS. Let's reuse it for AWS as well.

cloud-pipeline/workflows/pipe-common/scripts/mount_storage.py

Line 382 in f8a9088

if params['aws_token'] is not None or params['fuse_type'] == FUSE_PIPE_ID:

@sidoruka sidoruka added kind/enhancement New feature or request sys/cli Issues related to the pipe cli sys/core Issues related to core functionality (API, VM management, ...) goal/dorado ✨ labels Sep 8, 2020
@sidoruka sidoruka added this to the v0.17 milestone Sep 8, 2020
@tcibinan tcibinan added the state/underway Issues that are currently being solved/implemented label Sep 10, 2020
@tcibinan tcibinan mentioned this issue Sep 10, 2020
Merged
@mzueva mzueva added state/verify Issues that are already addressed and require validation and removed state/underway Issues that are currently being solved/implemented labels Sep 10, 2020
tcibinan added a commit that referenced this issue Sep 11, 2020
@tcibinan
Add missing fuse type parameter to GCPMounter.
a0d5049 
Relates to #1371.
mzueva pushed a commit that referenced this issue Sep 11, 2020
@tcibinan @mzueva
Add missing fuse type parameter to GCPMounter.
33008e9 
Relates to #1371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzueva mzueva

@tcibinan tcibinan

Labels
goal/dorado ✨ kind/enhancement New feature or request state/verify Issues that are already addressed and require validation sys/cli Issues related to the pipe cli sys/core Issues related to core functionality (API, VM management, ...)
Projects
None yet
Milestone
v0.17
Development

No branches or pull requests
3 participants
@mzueva @tcibinan @sidoruka