Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with a CSS parser for selector parsing #1086

Merged
merged 25 commits into from
Sep 16, 2017
Merged

Integrate with a CSS parser for selector parsing #1086

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8177e26
Implement new selector parsing module
Aug 21, 2017
0d4a7eb
Use new selector API in mount and shallow wrappers
Aug 21, 2017
51ff0e7
Implement findParentNode utility
Aug 21, 2017
26bf200
Rename selector tests file
Aug 21, 2017
fa80c0e
Stop treating unquoted strings as invalid
Aug 21, 2017
b18cfe4
Update tests
Aug 21, 2017
5dde9c6
Add more comments to selectors.js
Aug 21, 2017
f20b0c4
Linting fixes
Aug 21, 2017
d7abfbe
Remove ComplexSelector
Aug 21, 2017
8bffb8a
Remove old predicate/selector parsing utilities
Aug 21, 2017
10019da
Remove invalid attribute test
Aug 21, 2017
5efaf08
Throw an error for complex selectors in buildPredicate
Aug 21, 2017
83c6f04
Move combinator logic into discrete utility functions
Aug 21, 2017
8b3e008
Replace scalpel with new rst-selector-parser package
Aug 22, 2017
1a73724
Throw for pseudo-class and psuedo-element selectors
Aug 23, 2017
36e10d2
Add more tests for selectors
Aug 23, 2017
ae733ee
Add test for URLS in attribute values
Aug 25, 2017
60b6a86
Improve test coverage, use correct APIs
Sep 1, 2017
2c3227b
Remove uuid from enzyme package.json
Sep 1, 2017
d0d810e
Fix error type in selector assertion
Sep 1, 2017
459108a
Fix react prop test assertion
Sep 1, 2017
188ed1c
Use if/else for branching in selector predicate functions
Sep 1, 2017
17f366d
Add nodeHasProperty test for NaN and Infinity
Sep 13, 2017
aadbc4a
Add test for adjacent siblings in arrays
Sep 13, 2017
a79e150
Use _reactInternalFiber for 16 adapater
Sep 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Throw an error for complex selectors in buildPredicate
  • Loading branch information
Brandon Dail committed Sep 13, 2017
commit 5efaf08b89d4757f32e7a914cd2775ae48162727
11 changes: 10 additions & 1 deletion packages/enzyme-test-suite/test/selector-spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const tests = [
},
];

describe('ComplexSelector', () => {
describe('selectors', () => {
tests.forEach(({ describeMethod, name, renderMethod }) => {
describeMethod(name, () => {
it('simple descendent', () => {
Expand Down Expand Up @@ -173,6 +173,15 @@ describe('ComplexSelector', () => {
siblings.map(sibling => expect(sibling.text()).to.not.equal('Top'));
});

it('throws for complex selectors in simple selector methods', () => {
const wrapper = renderMethod(<div className="foo" />);
['is', 'filter', 'not', 'every'].forEach((method) => {
expect(() => wrapper[method]('.foo + div')).to.throw(
`This method does not support complex CSS selectors`
);
});
});

it('.foo + div > span', () => {
const wrapper = renderMethod(
<div>
Expand Down
2 changes: 1 addition & 1 deletion packages/enzyme/src/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export function buildPredicate(selector) {
case 'string': {
const tokens = safelyGenerateTokens(selector);
if (isComplexSelector(tokens)) {
// @TODO throw a helpful error.
throw new TypeError('This method does not support complex CSS selectors');
}
// Simple selectors only have a single selector token
return buildPredicateFromToken(tokens[0]);
Expand Down