We should always have a staticScope in hand

enebo · Dec 19, 2024 · 7554ac6 · 7554ac6
1 parent 4e925df
commit 7554ac6
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 1 deletion.
diff --git a/core/src/main/java/org/jruby/ir/runtime/IRRuntimeHelpers.java b/core/src/main/java/org/jruby/ir/runtime/IRRuntimeHelpers.java
@@ -1659,15 +1659,26 @@ public static RubyHash dupKwargsHashAndPopulateFromArray(ThreadContext context,
 
     @JIT
     public static IRubyObject searchConst(ThreadContext context, StaticScope staticScope, String constName, boolean noPrivateConsts) {
+<<<<<<< Updated upstream
         RubyModule object = objectClass(context);
         IRubyObject constant = staticScope == null ? object.getConstant(constName) : staticScope.getConstantInner(constName);
+=======
+        IRubyObject constant = staticScope.getScopedConstant(context, constName);
+>>>>>>> Stashed changes
 
         // Inheritance lookup
         RubyModule module = null;
         if (constant == null) {
+<<<<<<< Updated upstream
             // SSS FIXME: Is this null check case correct?
             module = staticScope == null ? object : staticScope.getModule();
             constant = noPrivateConsts ? module.getConstantFromNoConstMissing(constName, false) : module.getConstantNoConstMissing(constName);
+=======
+            module = staticScope.getModule();
+            constant = noPrivateConsts ?
+                    module.getConstantFromNoConstMissing(constName, false) :
+                    module.getConstantNoConstMissing(context, constName);
+>>>>>>> Stashed changes
         }
 
         // Call const_missing or cache

diff --git a/core/src/main/java/org/jruby/ir/targets/indy/ConstantLookupSite.java b/core/src/main/java/org/jruby/ir/targets/indy/ConstantLookupSite.java
@@ -80,18 +80,31 @@ private RubySymbol getSymbolicName(ThreadContext context) {
 
     public IRubyObject searchConst(ThreadContext context, StaticScope staticScope) {
         // Lexical lookup
+<<<<<<< Updated upstream
         RubyModule object = objectClass(context);
 
         // get switchpoint before value
         SwitchPoint switchPoint = getSwitchPointForConstant(context.runtime);
         IRubyObject constant = (staticScope == null) ? object.getConstant(name) : staticScope.getConstantInner(name);
+=======
+        // get switchpoint before value
+        SwitchPoint switchPoint = getSwitchPointForConstant(context.runtime);
+        IRubyObject constant = staticScope.getScopedConstant(context, name);
+>>>>>>> Stashed changes
 
         // Inheritance lookup
         RubyModule module = null;
         if (constant == null) {
+<<<<<<< Updated upstream
             // SSS FIXME: Is this null check case correct?
             module = staticScope == null ? object : staticScope.getModule();
             constant = publicOnly ? module.getConstantFromNoConstMissing(name, false) : module.getConstantNoConstMissing(name);
+=======
+            module = staticScope.getModule();
+            constant = publicOnly ?
+                    module.getConstantFromNoConstMissing(name, false) :
+                    module.getConstantNoConstMissing(context, name);
+>>>>>>> Stashed changes
         }
 
         // Call const_missing or cache

diff --git a/core/src/main/java/org/jruby/ir/targets/simple/ConstantLookupSite.java b/core/src/main/java/org/jruby/ir/targets/simple/ConstantLookupSite.java
@@ -25,16 +25,26 @@ public ConstantLookupSite(RubySymbol name) {
 
     private IRubyObject cacheSearchConst(ThreadContext context, StaticScope staticScope, boolean publicOnly) {
         // Lexical lookup
-        RubyModule object = objectClass(context);
         String id = this.id;
+<<<<<<< Updated upstream
         IRubyObject constant = (staticScope == null) ? object.getConstant(id) : staticScope.getConstantInner(id);
+=======
+        IRubyObject constant = staticScope.getScopedConstant(context, id);
+>>>>>>> Stashed changes
 
         // Inheritance lookup
         RubyModule module = null;
         if (constant == null) {
+<<<<<<< Updated upstream
             // SSS FIXME: Is this null check case correct?
             module = staticScope == null ? object : staticScope.getModule();
             constant = publicOnly ? module.getConstantFromNoConstMissing(id, false) : module.getConstantNoConstMissing(id);
+=======
+            module = staticScope.getModule();
+            constant = publicOnly ?
+                    module.getConstantFromNoConstMissing(id, false) :
+                    module.getConstantNoConstMissing(context, id);
+>>>>>>> Stashed changes
         }
 
         // Call const_missing or cache