Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Data JavaScript Modules API #238

Closed
wants to merge 6 commits into from
Closed

Ember Data JavaScript Modules API #238

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2083413
Create 0000-ember-data-javascript-module-api.md
locks Jul 25, 2017
dd5d9b5
Update 0000-ember-data-javascript-module-api.md
locks Jul 25, 2017
ac5c0b6
Update 0000-ember-data-javascript-module-api.md
locks Jul 25, 2017
8b5d114
Update 0000-ember-data-javascript-module-api.md
locks Jul 25, 2017
b4e9031
Update 0000-ember-data-javascript-module-api.md
locks Jul 25, 2017
1496320
Update 0000-ember-data-javascript-module-api.md
locks Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update 0000-ember-data-javascript-module-api.md
  • Loading branch information
@locks
locks authored Jul 25, 2017
commit b4e903138c07916bd0dc679869116792db201089
4 changes: 2 additions & 2 deletions text/0000-ember-data-javascript-module-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ byt theyhave their own name and namespace in the Ember container.
| Global | Module |
|--- | --- |
| `DS.Store` | `import Store from '@ember-data/store'` |
| `DS.AdapterPopulatedRecordArray` | `import AdapterPopulatedRecordArray from '@ember-data/store/src/src/adapter-populated-record-array'` |
| `DS.DebugAdapter` | `import DebugAdapter from '@ember-data/store/src/src/debug-adapter'` |
| `DS.AdapterPopulatedRecordArray` | `import AdapterPopulatedRecordArray from '@ember-data/store/src/adapter-populated-record-array'` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src in the module import path is needed due to the new module unification semantics, which obviously makes it a little harder to build nice looking APIs based on import paths. IMHO we should first figure out how we could accomplish nice looking paths and then afterwards think about new Ember Data module APIs. Otherwise we might create more churn than needed.

| `DS.DebugAdapter` | `import DebugAdapter from '@ember-data/store/src/debug-adapter'` |
| `DS.FilteredRecordArray` | `import FilteredRecordArray from '@ember-data/store/src/filterd-record-array'` |
| `DS.ManyArray` | `import ManyArray from '@ember-data/store/src/many-array'` |
| `DS.RecordArray` | `import RecordArray from '@ember-data/store/src/record-array'` |
Expand Down