Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing export of ScanType in cyw43 lib #3634

Closed
karimpanacci opened this issue Dec 10, 2024 · 3 comments
Closed

Missing export of ScanType in cyw43 lib #3634

karimpanacci opened this issue Dec 10, 2024 · 3 comments

Comments

@karimpanacci
Copy link
Contributor

karimpanacci commented Dec 10, 2024 •
edited
Loading

I can't build a ScanOptions struct because it requires the ScanType enum which is not exported by the library:

https://github.com/embassy-rs/embassy/blob/406d377b7564d16e12b7fae4f42c0c709bf4f243/cyw43/src/lib.rs
pub use crate::control::{AddMulticastAddressError, Control, Error as ControlError, ScanOptions, Scanner};

it should be like this:
pub use crate::control::{AddMulticastAddressError, Control, Error as ControlError, ScanOptions, Scanner, ScanType};
@Dirbaio
Copy link
Member

Dirbaio commented Dec 10, 2024

can you send a PR?

@karimpanacci
Copy link
Contributor Author

here it is: #3637

I'm a beginner in contributing to real projects, so I don't know if I did everything right

@Dirbaio
Copy link
Member

Dirbaio commented Jan 2, 2025

fixed in #3637

@Dirbaio Dirbaio closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dirbaio @karimpanacci