chore: remove unused ConvertableToTraceFormatWrapper #43356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
remove now-unused trace_event.h header, too
codebytere
approved these changes
Aug 20, 2024
github-actions
bot
added
the
target/33-x-y
jkleinsc
approved these changes
Aug 20, 2024
jkleinsc
deleted the
refactor/remove-unused-ConvertableToTraceFormatWrapper
branch
|
No Release Notes |
|
I was unable to backport this PR to "31-x-y" cleanly; |
|
I was unable to backport this PR to "32-x-y" cleanly; |
trop
bot
added
needs-manual-bp/31-x-y
and removed
target/31-x-y
|
I was unable to backport this PR to "33-x-y" cleanly; |
trop
bot
added
needs-manual-bp/32-x-y
needs-manual-bp/33-x-y
and removed
target/33-x-y
ckerr
added a commit
that referenced
this pull request
Aug 20, 2024
trop
bot
added
merged/33-x-y
|
@codebytere has manually backported this PR to "32-x-y", please check out #43646 |
trop
bot
added
in-flight/32-x-y
merged/32-x-y
This was referenced Sep 9, 2024
|
Looks like this is still used in 30-x-y; can't be removed there 💥 |
trop
bot
added
merged/31-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove unused helper class
ConvertableToTraceFormatWrapperand unique_ptr trace helper.Last use removed in Apr 2024 (39bf441, #41880)
Checklist
npm testpassesRelease Notes
Notes: none.