Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: enable Perfetto in Chromium #41880

Merged
merged 5 commits into from
Apr 19, 2024
Merged

build: enable Perfetto in Chromium #41880

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de7bcd6
build: enable perfetto in Chromium
codebytere Apr 17, 2024
bcb04ae
refactor: delete TracingControllerImpl
codebytere Apr 17, 2024
e618b64
fix: TraceObject isn't present when v8_use_perfetto is true
codebytere Apr 17, 2024
b5bb543
fix: update lib/internal/http for perfetto
codebytere Apr 18, 2024
b9f000a
chore: remove stray log
codebytere Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: remove stray log
  • Loading branch information
@codebytere
codebytere committed Apr 19, 2024
commit b9f000a2e2da9650e8b64c64f405697aec2f6e60
6 changes: 2 additions & 4 deletions patches/node/build_enable_perfetto.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ index 8d7204f6cb48f783adc4d1c1eb2de0c83b7fffe2..a154559a56bf383d3c26af523c9bb07b

// Non-alphabetic chars.
diff --git a/lib/internal/http.js b/lib/internal/http.js
index b20b3cd229efcd9701791309361b7d106f315900..f708557b87a0f695e1f9e649dcd83f95fdbc6d59 100644
index b20b3cd229efcd9701791309361b7d106f315900..6b2820c9dcce5e658b694f53e75d93707c4320d7 100644
--- a/lib/internal/http.js
+++ b/lib/internal/http.js
@@ -10,8 +10,8 @@ const {
Expand All @@ -47,20 +47,18 @@ index b20b3cd229efcd9701791309361b7d106f315900..f708557b87a0f695e1f9e649dcd83f95
} = require('internal/constants');

let utcCache;
@@ -44,11 +44,15 @@ function isTraceHTTPEnabled() {
@@ -44,11 +44,13 @@ function isTraceHTTPEnabled() {
const traceEventCategory = 'node,node.http';

function traceBegin(...args) {
- trace(CHAR_LOWERCASE_B, traceEventCategory, ...args);
+ // See v8/src/builtins/builtins-trace.cc - must be uppercase for perfetto
+ console.log('trace with CHAR_UPPERCASE_B: ', CHAR_UPPERCASE_B)
+ trace(CHAR_UPPERCASE_B, traceEventCategory, ...args);
}

function traceEnd(...args) {
- trace(CHAR_LOWERCASE_E, traceEventCategory, ...args);
+ // See v8/src/builtins/builtins-trace.cc - must be uppercase for perfetto
+ console.log('trace with CHAR_UPPERCASE_E: ', CHAR_UPPERCASE_E)
+ trace(CHAR_UPPERCASE_E, traceEventCategory, ...args);
}

Expand Down