refactor: add metadata to view classes

Ref: https://chromium-review.googlesource.com/c/chromium/src/+/4994885
electron · nornagon · Nov 28, 2023 · Nov 14, 2023 · Nov 14, 2023 · Nov 14, 2023
commit 7f670615b6fc627d8aa96586ed12ff326f74a3d3
diff --git a/shell/browser/ui/views/autofill_popup_view.cc b/shell/browser/ui/views/autofill_popup_view.cc
@@ -30,6 +30,9 @@ void AutofillPopupChildView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
   node_data->SetName(suggestion_);
 }
 
+BEGIN_METADATA(AutofillPopupChildView)
+END_METADATA
+
 AutofillPopupView::AutofillPopupView(AutofillPopup* popup,
                                      views::Widget* parent_widget)
     : popup_(popup), parent_widget_(parent_widget) {

diff --git a/shell/browser/ui/views/autofill_popup_view.h b/shell/browser/ui/views/autofill_popup_view.h
@@ -16,6 +16,8 @@
 #include "shell/browser/osr/osr_view_proxy.h"
 #include "third_party/abseil-cpp/absl/types/optional.h"
 #include "ui/accessibility/ax_node_data.h"
+#include "ui/base/metadata/metadata_header_macros.h"
+#include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/views/drag_controller.h"
 #include "ui/views/focus/widget_focus_manager.h"
 #include "ui/views/widget/widget_delegate.h"
@@ -34,6 +36,8 @@ class AutofillPopup;
 // Child view only for triggering accessibility events. Rendering is handled
 // by |AutofillPopupViewViews|.
 class AutofillPopupChildView : public views::View {
+  METADATA_HEADER(AutofillPopupChildView, views::View)
+
  public:
   explicit AutofillPopupChildView(const std::u16string& suggestion)
       : suggestion_(suggestion) {

diff --git a/shell/browser/ui/views/menu_bar.cc b/shell/browser/ui/views/menu_bar.cc
@@ -270,4 +270,7 @@ void MenuBar::UpdateViewColors() {
 #endif
 }
 
+BEGIN_METADATA(MenuBar)
+END_METADATA
+
 }  // namespace electron
diff --git a/shell/browser/ui/views/menu_bar.h b/shell/browser/ui/views/menu_bar.h
@@ -10,6 +10,8 @@
 #include "shell/browser/ui/electron_menu_model.h"
 #include "shell/browser/ui/views/menu_delegate.h"
 #include "shell/browser/ui/views/root_view.h"
+#include "ui/base/metadata/metadata_header_macros.h"
+#include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/views/accessible_pane_view.h"
 
 namespace views {
@@ -21,6 +23,8 @@ namespace electron {
 class MenuBar : public views::AccessiblePaneView,
                 public MenuDelegate::Observer,
                 public NativeWindowObserver {
+  METADATA_HEADER(MenuBar, views::AccessiblePaneView)
+
  public:
   static const char kViewClassName[];
 

diff --git a/shell/browser/ui/views/submenu_button.cc b/shell/browser/ui/views/submenu_button.cc
@@ -96,4 +96,7 @@ void SubmenuButton::GetCharacterPosition(const std::u16string& text,
                              &height, 0, 0);
 }
 
+BEGIN_METADATA(SubmenuButton)
+END_METADATA
+
 }  // namespace electron
diff --git a/shell/browser/ui/views/submenu_button.h b/shell/browser/ui/views/submenu_button.h
@@ -8,13 +8,17 @@
 #include <string>
 
 #include "ui/accessibility/ax_node_data.h"
+#include "ui/base/metadata/metadata_header_macros.h"
+#include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/views/animation/ink_drop_highlight.h"
 #include "ui/views/controls/button/menu_button.h"
 
 namespace electron {
 
 // Special button that used by menu bar to show submenus.
 class SubmenuButton : public views::MenuButton {
+  METADATA_HEADER(SubmenuButton, views::MenuButton)
+
  public:
   SubmenuButton(PressedCallback callback,
                 const std::u16string& title,

diff --git a/shell/browser/ui/views/win_caption_button.cc b/shell/browser/ui/views/win_caption_button.cc
@@ -211,4 +211,8 @@ void WinCaptionButton::PaintSymbol(gfx::Canvas* canvas) {
       return;
   }
 }
+
+BEGIN_METADATA(WinCaptionButton)
+END_METADATA
+
 }  // namespace electron
diff --git a/shell/browser/ui/views/win_caption_button.h b/shell/browser/ui/views/win_caption_button.h
@@ -14,6 +14,7 @@
 #include "chrome/browser/ui/view_ids.h"
 #include "shell/browser/ui/views/win_icon_painter.h"
 #include "ui/base/metadata/metadata_header_macros.h"
+#include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/controls/button/button.h"
 
@@ -22,6 +23,8 @@ namespace electron {
 class WinFrameView;
 
 class WinCaptionButton : public views::Button {
+  METADATA_HEADER(WinCaptionButton, views::Button)
+
  public:
   WinCaptionButton(PressedCallback callback,
                    WinFrameView* frame_view,

diff --git a/shell/browser/ui/views/win_caption_button_container.cc b/shell/browser/ui/views/win_caption_button_container.cc
@@ -188,4 +188,8 @@ void WinCaptionButtonContainer::UpdateButtons() {
 
   InvalidateLayout();
 }
+
+BEGIN_METADATA(WinCaptionButtonContainer)
+END_METADATA
+
 }  // namespace electron
diff --git a/shell/browser/ui/views/win_caption_button_container.h b/shell/browser/ui/views/win_caption_button_container.h
@@ -11,6 +11,7 @@
 #include "base/memory/raw_ptr.h"
 #include "base/scoped_observation.h"
 #include "ui/base/metadata/metadata_header_macros.h"
+#include "ui/base/metadata/metadata_impl_macros.h"
 #include "ui/base/pointer/touch_ui_controller.h"
 #include "ui/views/controls/button/button.h"
 #include "ui/views/view.h"
@@ -27,6 +28,8 @@ class WinCaptionButton;
 // grab bar for moving the window.
 class WinCaptionButtonContainer : public views::View,
                                   public views::WidgetObserver {
+  METADATA_HEADER(WinCaptionButtonContainer, views::View)
+
  public:
   explicit WinCaptionButtonContainer(WinFrameView* frame_view);
   ~WinCaptionButtonContainer() override;