Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: full support for persistent HTML5 notifications #35810

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
+1,505 −178
Open

feat: full support for persistent HTML5 notifications #35810

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
bea2c36
feat: BREAKING CHANGE: full support for HTML5 notifications (WIN and …
YuriL180821 Sep 25, 2022
429b05b
fix: resolve problem with Notifications BrowserContext
YuriL180821 Dec 23, 2021
4250b8d
feat: workaround with toast scenario type to allow infinite toast dis…
YuriL180821 Dec 9, 2021
0afafcd
feat: support for put_SuppressPopup to establish renotify property (WIN)
YuriL180821 Jan 10, 2022
0d3601b
feat: initial commit for renotify feature support (MacOS)
YuriL180821 Feb 7, 2022
6a7fc1c
fix: full support for renotify property
YuriL180821 Feb 16, 2022
3e35815
fix: silencing IncommingCall sound and playing default sound by PlayS…
YuriL180821 Feb 8, 2022
1367c22
feat: support image property for XML scheme and necessary refactoring…
YuriL180821 Feb 17, 2022
9c2dfc1
fix: swap for icon and image paths
YuriL180821 Mar 5, 2022
9746861
feat: support notificationsComDisplayName property
YuriL180821 Mar 21, 2022
eab0882
fix: refine requireInterraction silent scheme
YuriL180821 May 20, 2022
1126ea6
fix: replace base::PostTask to content::GetUIThreadTaskRunner
YuriL180821 Jun 16, 2022
05f154e
fix: changes regarding new prototype of WebNotificationAllowed
YuriL180821 Sep 25, 2022
e7fd2f2
fix: signed / unsigned comparison
YuriL180821 Sep 25, 2022
a5e2de4
fix: lint check errors
YuriL180821 Sep 27, 2022
de76a80
Revert "feat: initial commit for renotify feature support (MacOS)"
YuriL180821 Oct 7, 2022
ce712f2
temporary exclusion MacOS environment
YuriL180821 Oct 7, 2022
dff6937
fix: Requested landing changes for Windows platform
YuriL180821 Feb 20, 2023
02eb717
fix: lint check errors
YuriL180821 Apr 8, 2023
76e5bb8
revert changes for electron_browser_context.cc from 1359c9d3ca10e950d…
YuriL180821 Apr 8, 2023
d4f6df3
Revert "fix: resolve problem with Notifications BrowserContext"
YuriL180821 Apr 8, 2023
25f1478
feat: make earlier exit in case if Notification::WebContents is nullptr
YuriL180821 Apr 9, 2023
541a217
feat: v8 data property processing
YuriL180821 May 9, 2023
5cca79c
feat: full simplification for the HTML5 notifications feature
YuriL180821 May 7, 2023
60e8601
fix test for app_name in api-notification-dbus-spec.ts
YuriL180821 May 7, 2023
fa236b0
feat: impovement for WRL::Activate parameters packing into json
YuriL180821 May 12, 2023
d9fbdc6
fix: replacement bare BrowserContext pointer on raw_ptr
YuriL180821 May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: refine requireInterraction silent scheme
  • Loading branch information
@YuriL180821
YuriL180821 committed May 14, 2023
commit eab0882841b7faeb9d4a22cc82c212abfb989378
18 changes: 9 additions & 9 deletions shell/browser/notifications/win/windows_toast_notification.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,13 +433,6 @@ HRESULT WindowsToastNotification::SetToastXml(
"XML: Setting \"scenario\" option on notification failed");
}

// Configure the toast's notification sound
if (silent) {
REPORT_AND_RETURN_IF_FAILED(
SetXmlAudioSilent(toast_xml),
"XML: Setting \"silent\" option on notification failed");
}

if (require_interaction) {
// Reimplement for SAP-17772 SAP-19442
const bool use_reminder =
Expand All @@ -449,12 +442,19 @@ HRESULT WindowsToastNotification::SetToastXml(
SetXmlScenarioType(
toast_xml,
std::wstring(use_reminder ? L"reminder" : L"incomingcall")),
"XML: Setting \"reminder\" senarion type failed");
"XML: Setting \"reminder\" scenario type failed");
}

// Configure the toast's notification sound
if (silent || require_interaction) {
// SAP-17738 - Can not require interaction on Windows
// Workaround to silent system IncommingCall sound and play Default sound by
// custom PlaySound call
// SAP-21082 - Notification showing up with strange sounds when
// requireInteraction is true require_interaction is necessary to fix side
// effect from applying incomingcall
REPORT_AND_RETURN_IF_FAILED(
SetXmlAudioSilent(*toast_xml),
SetXmlAudioSilent(toast_xml),
"XML: Setting \"silent\" option on notification failed");
}

Expand Down