Make Print API work on Windows. #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are some output. Print through
Print through real printer
|
|
We would like to see printing / PDF support show up in Electron for sure, especially viewing PDFs |
|
@zcbenz |
|
Awesome! v0.25.3 is released with PDF libraries, and the binary size is increased by about 14mb, I agree we should make it a DLL. We can probably patch libchromiumcontent to compile |
zcbenz
added a commit
that referenced
this pull request
May 10, 2015
Make Print API work on Windows.
zcbenz
added a commit
that referenced
this pull request
May 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Print API(
window.print()) on Windows will hang on printing spool(see #865). The reason is that Chromium doesn't generate the printed file content and keep waiting in a loop.In the implementation, Chromium seperates a prcoess called
Utilityto do the printing work, so we need to custom theUtilityprocess for Electron. On Windows, the print API relies on thepdfcomponent which using to convert to EMF(see https://code.google.com/p/chromium/issues/detail?id=170859). So we need to port
pdfcomponent inlibchromiumcontent.But there are something need to be considered. Introducing
pdfcomponent will make the release binary size larger. Is this reaonable? Or we can make thepdfas a seperated shared library(dll), and if developers don't need the print API, they can safely remove it in saving the binary size.As a side effect, with
pdfcomponent, we may easyly supportprint to pdfandview pdffeatures.This patch will rely on electron/libchromiumcontent#104, and fix #865.
Any comments and advice are welcomed.
TODO