Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert arguments to V8 directly in EventEmitter::Emit #1009

Merged
merged 8 commits into from
Jan 16, 2015
Merged

Convert arguments to V8 directly in EventEmitter::Emit #1009

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65d2540
Use C++11 stdlib
zcbenz Jan 15, 2015
2d6dc9c
Convert arguments to V8 directly in EventEmitter::Emmit
zcbenz Jan 15, 2015
6a11ecc
Update native_mate to fix linking error
zcbenz Jan 15, 2015
f6f5ff4
Fix converting ListValue to V8
zcbenz Jan 15, 2015
1a1cf57
Unpack the arguments in ipc message
zcbenz Jan 15, 2015
482c740
Also unpack arguments in ipc-message-host message
zcbenz Jan 15, 2015
9f5ed14
mac: Upgrade libchromiumcontent to fix linking error
zcbenz Jan 15, 2015
136b3da
Add -stdlib=libc++ for linking
zcbenz Jan 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix converting ListValue to V8
  • Loading branch information
@zcbenz
zcbenz committed Jan 15, 2015
commit f6f5ff433021e548b6165ff46c2d5efcf8802a6d
3 changes: 2 additions & 1 deletion atom/common/native_mate_converters/value_converter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ bool Converter<base::ListValue>::FromV8(v8::Isolate* isolate,
v8::Handle<v8::Value> Converter<base::ListValue>::ToV8(
v8::Isolate* isolate,
const base::ListValue& val) {
return v8::Undefined(isolate);
scoped_ptr<atom::V8ValueConverter> converter(new atom::V8ValueConverter);
return converter->ToV8Value(&val, isolate->GetCurrentContext());
}

} // namespace mate