Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Streams 🌊] Add processors validation and simulation gate (#206566) #206803

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…6566)

## 📓 Summary

Closes elastic/streams-program#66

This work adds changes to prevent invalid processors from being
submitted.
The main rule is that a simulation is performed before any add/edit
submission to guarantee that the processor config is valid.

This work also updates the simulation API to detect whether there is a
non-additive change in any simulated document.

@patpscal error reporting UI for add/edit is different since the
simulator is not visible for edit, I used a callout but we can easily
update this once there is a final design in place.

### Form validation + simulation

https://github.com/user-attachments/assets/f7fc351b-6efc-4500-8490-b7f1c85139bf

### Non-additive processors

https://github.com/user-attachments/assets/47b5b739-c2cf-4a74-93a8-6ef43521c7d4
(cherry picked from commit 6429c53)
@kibanamachine kibanamachine merged commit 45f7274 into elastic:8.x Jan 15, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 265 269 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 269.6KB 272.0KB +2.4KB
Unknown metric groups

ESLint disabled in files

id before after diff
streamsApp 2 3 +1

Total ESLint disabled count

id before after diff
streamsApp 5 6 +1

cc @tonyghiani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants