Remove exits from filebeat #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove panic recovery as should not be handled inside the beat.
ruflin
force-pushed
the
remove-filebeat-exit
branch
from
db0a7dc to
5deb914
Compare
|
LGTM |
|
To clarify, is this change being made so that the Beat will use the godaemon process to restart it on failure? |
|
@andrewkroh This is mainly a cleanup of filebeat. I don't think the beats itself should exit but return errors. Some of this code was still coming from lsf. Returning errors will also make the shutdown smoother. |
|
That all makes sense. I misread the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove panic recovery as should not be handled inside the beat. Same for exists. Beats should always properly be shut down whenever possible.
Add changelog for missing changelog in #644