MAINT Parameters validation for datasets.make_swiss_roll (scikit-lear…

…n#26020)
ekaterinabutyugina · Mar 30, 2023 · 5f1c4f2 · 5f1c4f2
1 parent 70c489f
commit 5f1c4f2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/sklearn/datasets/_samples_generator.py b/sklearn/datasets/_samples_generator.py
@@ -1627,6 +1627,14 @@ def make_sparse_spd_matrix(
     return prec
 
 
+@validate_params(
+    {
+        "n_samples": [Interval(Integral, 1, None, closed="left")],
+        "noise": [Interval(Real, 0, None, closed="left")],
+        "random_state": ["random_state"],
+        "hole": ["boolean"],
+    }
+)
 def make_swiss_roll(n_samples=100, *, noise=0.0, random_state=None, hole=False):
     """Generate a swiss roll dataset.
 

diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py
@@ -146,6 +146,7 @@ def _check_function_param_validation(
     "sklearn.datasets.make_sparse_spd_matrix",
     "sklearn.datasets.make_sparse_uncorrelated",
     "sklearn.datasets.make_spd_matrix",
+    "sklearn.datasets.make_swiss_roll",
     "sklearn.decomposition.sparse_encode",
     "sklearn.feature_extraction.grid_to_graph",
     "sklearn.feature_extraction.img_to_graph",