Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass custom metrics to geodesic code. #625

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add ability to pass custom metrics to geodesic code. #625

merged 1 commit into from
Nov 15, 2022

Conversation

a3ahmad
Copy link
Contributor

@a3ahmad a3ahmad commented Nov 13, 2022

Add ability to provide a metric-generating function to Geodesics

@auto-assign auto-assign bot requested a review from JeS24 November 13, 2022 15:14
@codecov
Copy link

codecov bot commented Nov 13, 2022 •
edited
Loading

Codecov Report

Merging #625 (31ddeb0) into main (e86a659) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 31ddeb0 differs from pull request most recent head b92e66f. Consider uploading reports for the commit b92e66f to get more accurate results

@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          68       68           
  Lines        2512     2515    +3     
=======================================
+ Hits         2445     2448    +3     
  Misses         67       67
Impacted Files Coverage Δ
src/einsteinpy/geodesic/geodesic.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeS24
Copy link
Member

JeS24 commented Nov 13, 2022

Hi @a3ahmad. Thanks for the PR. I am busy right now. I can post a proper review after around 2-3 hours. Although, at a glance, the addition seems fine. You will have to add a unit-test so that Code Coverage does not decrease. But wait till I post the review.

JeS24
JeS24 approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@JeS24 JeS24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Two things needed:

  • A unit-test, so that the Codecov check passes.
  • Add your (GitHub) name and a one-line summary of the change to the CHANGELOG.

Future ref (for maintainers):

  • Create an issue to add / edit a Jupyter notebook example that showcases the addition in this PR. @JeS24

src/einsteinpy/geodesic/geodesic.py Show resolved Hide resolved
@JeS24
Copy link
Member

JeS24 commented Nov 14, 2022

@a3ahmad Can you also squash the last few commits into one? Feel free to ask if you face issues.

@a3ahmad
Copy link
Contributor Author

a3ahmad commented Nov 14, 2022

@JeS24 Simplified the unit test, as suggested, and squashed the commits.

@JeS24
Copy link
Member

JeS24 commented Nov 14, 2022

@a3ahmad Can you force push once more? The AppVeyor test failed due to some Cloudfare issue at the time.

@a3ahmad
Copy link
Contributor Author

a3ahmad commented Nov 14, 2022

@JeS24 Done. Looks like all the tests pass, now.

@JeS24 JeS24 mentioned this pull request Nov 15, 2022
Open
3 tasks
@JeS24
Copy link
Member

JeS24 commented Nov 15, 2022

Thanks @a3ahmad. Merging now.

@JeS24 JeS24 merged commit e7f648b into einsteinpy:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeS24 JeS24 JeS24 approved these changes

Assignees
No one assigned
Labels
2 - Ready geodesics metric
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a3ahmad @JeS24