Expose timers API #327
Open
Expose timers API #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandrHoroshih
approved these changes
Apr 23, 2024
sergeysova
requested changes
May 14, 2024
Comment on lines
+207
to
+221
| const timerFx = createEffect(({ canceller, timeout }: DebounceTimerFxProps) => { | ||
| const { timeoutId, rejectPromise } = canceller; | ||
|
|
||
| if (timeoutId) clearTimeout(timeoutId); | ||
| if (rejectPromise) rejectPromise(); | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| canceller.timeoutId = setTimeout(resolve, timeout); | ||
| canceller.rejectPromise = reject; | ||
| }); | ||
| }); | ||
|
|
||
| const scope = fork({ | ||
| handlers: [[debounce.timerFx, timerFx]], | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const timerFx = createEffect(({ canceller, timeout }: DebounceTimerFxProps) => { | |
| const { timeoutId, rejectPromise } = canceller; | |
| if (timeoutId) clearTimeout(timeoutId); | |
| if (rejectPromise) rejectPromise(); | |
| return new Promise((resolve, reject) => { | |
| canceller.timeoutId = setTimeout(resolve, timeout); | |
| canceller.rejectPromise = reject; | |
| }); | |
| }); | |
| const scope = fork({ | |
| handlers: [[debounce.timerFx, timerFx]], | |
| }); | |
| const handleTimer = ({ canceller, timeout }): DebounceTimerFxProps => { | |
| const { timeoutId, rejectPromise } = canceller; | |
| if (timeoutId) clearTimeout(timeoutId); | |
| if (rejectPromise) rejectPromise(); | |
| return new Promise((resolve, reject) => { | |
| canceller.timeoutId = setTimeout(resolve, timeout); | |
| canceller.rejectPromise = reject; | |
| }); | |
| }); | |
| const scope = fork({ | |
| handlers: [[debounce.timerFx, handleTimer]], | |
| }); |
handler should be function
| @@ -29,7 +49,7 @@ export function debounce< | |||
| target: Target; | |||
| name?: string; | |||
| }): Target; | |||
| export function debounce<T>( | |||
| export function _debounce<T>( | |||
There was a problem hiding this comment.
Why this export of _debounce is necessary?
| @@ -186,19 +186,23 @@ describe('edge cases', () => { | |||
| test('does not call target twice for sample chain doubles', async () => { | |||
| const trigger = createEvent(); | |||
|
|
|||
| const scope = fork(); | |||
There was a problem hiding this comment.
Scope should be created AFTER the model initialization.
Comment on lines
+194
to
+198
| createWatch({ | ||
| unit: db, | ||
| fn: listener, | ||
| scope, | ||
| }) |
There was a problem hiding this comment.
This should be moved just before await allSettled(start, { scope })
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist for a new method
srcdirectory inparam-casesrc/method-name/index.tsin ESModules export incamelCasenamed exportsrc/method-name/method-name.test.tssrc/method-name/method-name.fork.test.tstest-typings/method-name.ts// @ts-expect-errorto mark expected type errorimport { expectType } from 'tsd'to check expected return typesrc/method-name/readme.mdPatronum/MethodNameMotivation,Formulae,ArgumentsandReturnsections for each overloadExamplesection for each overloadREADME.mdin the repository root- [MethodName](#methodname) - description.## MethodName[Method documentation & API](/src/method-name)into section