Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit cursor fix #1

Merged
merged 1 commit into from
Jul 5, 2022
Merged

edit cursor fix #1

merged 1 commit into from
Jul 5, 2022

Conversation

s-n-g
Copy link
Contributor

@s-n-g s-n-g commented Jul 4, 2022 •
edited
Loading

Hi @edunfelt

I have noticed that the edit cursor feels kinda off... I have set it the same as the Stations colors

I wasn't able to recreate the themes (make threw errors), but I edited them and here we are :)

I also have three videos for you

  1. Cycling through all the themes - em1.mkv
  2. Original Edit Cursor - em2.mkv
  3. Modified Edit Cursor: em3.mkv

Have a look and tell me what you think...

@s-n-g s-n-g mentioned this pull request Jul 4, 2022
Closed
@edunfelt
Copy link
Owner

edunfelt commented Jul 5, 2022

Hi @s-n-g!

Phew this took me longer than it should to troubleshoot.. the make issues are due to tinted-theming/home#39 which seems to have just occurred unfortunately.

I have switched to the node builder for now, which is probably a better idea honestly since it's officially supported. Would you mind pulling the latest changes to see if it works better now? Note that some scheme-files probably have changed now.

As for the cursor change this looks much better - thanks for catching this! Merging.

@edunfelt edunfelt merged commit ccb8c7d into edunfelt:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-n-g @edunfelt