Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import not supported in aws documentation + cli help correction #230

Merged
merged 5 commits into from
Sep 9, 2022
Merged

Import not supported in aws documentation + cli help correction #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ff8723
Import not supported error + documentation
AbineshECAD Jul 21, 2022
7f12b57
Import help corrected to <secret-key> from <pkh>
AbineshECAD Jul 21, 2022
d404e21
Merge branch 'main' of github.com:ecadlabs/signatory into aws-import
AbineshECAD Jul 27, 2022
93c591e
Merge branch 'main' of github.com:ecadlabs/signatory into aws-import
AbineshECAD Aug 26, 2022
6d003a1
Removed aws changes
AbineshECAD Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/commands/import.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ func NewImportCommand(c *Context) *cobra.Command {
)

importCmd := &cobra.Command{
Use: "import <pkh>",
Use: "import <secret-key>",
Short: "Import Tezos private keys (edsk..., spsk..., p2sk...)",
Args: cobra.MinimumNArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
Expand Down
4 changes: 3 additions & 1 deletion docs/aws_kms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,6 @@ access_key_id | string | OPTIONAL | IAM user detail
secret_access_key | string | OPTIONAL | IAM user detail
region | string | ✅ | Region where key is created

The fields `access_key_id` & `secret_access_key` can be set in the environment variables `AWS_ACCESS_KEY_ID` & `AWS_SECRET_ACCESS_KEY` respectively.
The fields `access_key_id` & `secret_access_key` can be set in the environment variables `AWS_ACCESS_KEY_ID` & `AWS_SECRET_ACCESS_KEY` respectively.

Import command is not available for aws as there is no support for asymmetric keys in AWS KMS. (Ref: <https://docs.aws.amazon.com/kms/latest/developerguide/importing-keys.html>)