Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with wildcard BUILD & flags #3867

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix bug with wildcard BUILD & flags #3867

merged 1 commit into from
Mar 5, 2024

Conversation

mikejholly
Copy link
Contributor

Addresses: #3862

The code should replace the wildcard target with the expanded one while accounting for flags & args.

@mikejholly mikejholly requested a review from a team as a code owner March 4, 2024 20:14
@mikejholly mikejholly requested a review from alexcb March 5, 2024 17:02
@mikejholly mikejholly merged commit 2b02a08 into main Mar 5, 2024
84 checks passed
@mikejholly mikejholly deleted the mh/build-auto-skip-wildcard branch March 5, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcb alexcb alexcb approved these changes

@vladaionescu vladaionescu vladaionescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
core
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikejholly @vladaionescu @alexcb