Add note about performance, update NEWS.

dysosmus · Dec 3, 2015 · 826d050 · 826d050
1 parent 5e9d957
commit 826d050
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/NEWS b/NEWS
@@ -21,6 +21,9 @@
 
   * Fix inconsistent handling of trailing slashes for DictRefsContainer. (#383)
 
+  * Add hack to support thin packs duing fetch(), albeit while requiring the
+    entire pack file to be loaded into memory. (jsbain)
+
  CHANGES
 
   * This will be the last release to support Python 2.6.

diff --git a/dulwich/client.py b/dulwich/client.py
@@ -234,6 +234,8 @@ def fetch(self, path, target, determine_wants=None, progress=None):
         if determine_wants is None:
             determine_wants = target.object_store.determine_wants_all
         if CAPABILITY_THIN_PACK in self._fetch_capabilities:
+           # TODO(jelmer): Avoid reading entire file into memory and
+           # only processing it after the whole file has been fetched.
            f = BytesIO()
            def commit():
               if f.tell():