Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test problem with jsdom >= 11.12.0 #80

Closed
mcjazzyfunky opened this issue Aug 20, 2018 · 3 comments
Closed

Unit test problem with jsdom >= 11.12.0 #80

mcjazzyfunky opened this issue Aug 20, 2018 · 3 comments

Comments

@mcjazzyfunky
Copy link
Collaborator

mcjazzyfunky commented Aug 20, 2018 •
edited
Loading

The following unit test in "Render.spec.js" fails if a "jsdom" version >= 11.12.0 is used:

it('should render dash case styles', () => {
  render(h('div', {style: {'-webkit-transform': 'scale(2)'}}), container)
  assert.equal(container.firstChild.style.WebkitTransform, 'scale(2)')
})

As a quick workaround the jsdom version in package.json has been set to "11.11.0" in branch "issue76".
@thysultan
Copy link
Member

Can refactoring it to use the string getter container.firstChild.style.cssText instead of the implied vendor specific property fix this?

@mcjazzyfunky
Copy link
Collaborator Author

I think it's just a bug in the latest two releases of the cssstyle library.

BTW: Seems the older versions of the cssstyle library also had an issue:
I think it should be style.webkitTransform, not style.WebkitTransform => lower-case "W"

To be continued....

@mcjazzyfunky
Copy link
Collaborator Author

See: jsdom/cssstyle#70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thysultan @mcjazzyfunky