Add interface to logstash client

dvhh · Feb 12, 2023 · 4cfa06a · 4cfa06a
1 parent 621a526
commit 4cfa06a
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 8 deletions.
diff --git a/collectors/collector_manager.go b/collectors/collector_manager.go
@@ -34,7 +34,7 @@ func NewCollectorManager(endpoint string) *CollectorManager {
 	return &CollectorManager{collectors: collectors, scrapeDurations: scrapeDurations}
 }
 
-func getCollectors(client *logstashclient.Client) map[string]Collector {
+func getCollectors(client logstashclient.Client) map[string]Collector {
 	collectors := make(map[string]Collector)
 	collectors["nodeinfo"] = nodestats.NewNodestatsCollector(client)
 	return collectors

diff --git a/collectors/nodestats/nodeinfo_collector.go b/collectors/nodestats/nodeinfo_collector.go
@@ -12,7 +12,7 @@ import (
 )
 
 type NodestatsCollector struct {
-	client *logstashclient.Client
+	client logstashclient.Client
 
 	NodeInfos  *prometheus.Desc
 	BuildInfos *prometheus.Desc
@@ -24,7 +24,7 @@ type NodestatsCollector struct {
 	Status *prometheus.Desc
 }
 
-func NewNodestatsCollector(client *logstashclient.Client) *NodestatsCollector {
+func NewNodestatsCollector(client logstashclient.Client) *NodestatsCollector {
 	const subsystem = "info"
 	namespace := config.PrometheusNamespace
 	descHelper := helpers.SimpleDescHelper{Namespace: namespace, Subsystem: subsystem}

diff --git a/collectors/nodestats/nodeinfo_collector_test.go b/collectors/nodestats/nodeinfo_collector_test.go
@@ -0,0 +1,25 @@
+package nodestats
+
+import (
+	"encoding/json"
+	"io/ioutil"
+
+	"github.com/kuskoman/logstash-exporter/fetcher/responses"
+)
+
+type mockClient struct{}
+
+func (m *mockClient) GetNodeInfo() (*responses.NodeInfoResponse, error) {
+	b, err := ioutil.ReadFile("node_info.json")
+	if err != nil {
+		return nil, err
+	}
+
+	var nodeInfo responses.NodeInfoResponse
+	err = json.Unmarshal(b, &nodeInfo)
+	if err != nil {
+		return nil, err
+	}
+
+	return &nodeInfo, nil
+}
diff --git a/fetcher/logstash_client/client.go b/fetcher/logstash_client/client.go
@@ -1,14 +1,21 @@
 package logstashclient
 
-import "github.com/kuskoman/logstash-exporter/httphandler"
+import (
+	"github.com/kuskoman/logstash-exporter/fetcher/responses"
+	"github.com/kuskoman/logstash-exporter/httphandler"
+)
 
-type Client struct {
+type DefaultClient struct {
 	httpClient httphandler.HTTPHandler
 }
 
+type Client interface {
+	GetNodeInfo() (*responses.NodeInfoResponse, error)
+}
+
 const defaultLogstashEndpoint = "http://localhost:9600"
 
-func NewClient(httpClient httphandler.HTTPHandler) *Client {
+func NewClient(httpClient httphandler.HTTPHandler) *DefaultClient {
 	var clientHandler httphandler.HTTPHandler
 
 	if httpClient == nil {
@@ -18,5 +25,5 @@ func NewClient(httpClient httphandler.HTTPHandler) *Client {
 		clientHandler = httpClient
 	}
 
-	return &Client{httpClient: clientHandler}
+	return &DefaultClient{httpClient: clientHandler}
 }
diff --git a/fetcher/logstash_client/queries.go b/fetcher/logstash_client/queries.go
@@ -5,7 +5,7 @@ import (
 	"github.com/kuskoman/logstash-exporter/httphandler"
 )
 
-func (c *Client) GetNodeInfo() (*responses.NodeInfoResponse, error) {
+func (c *DefaultClient) GetNodeInfo() (*responses.NodeInfoResponse, error) {
 	var nodeInfoResponse responses.NodeInfoResponse
 	err := httphandler.GetMetrics(c.httpClient, &nodeInfoResponse)
 	if err != nil {