correctly display text under cursor in underdash/vertical line cursor mode #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mTextPaint.setColor(mPalette[TextStyle.ciCursorForeground]); | ||
| // Only use invert color with BLOCK cursor. | ||
| // For underdash and vertical line, use normal color. | ||
| if(mCursorStyle == 0) { |
There was a problem hiding this comment.
Beside this location, there is no other external use of mCursorStyle, it might be slightly better to keep it private and access via an accessor ( for a small potential performance cost, but better isolation ).
|
fixed. :) |
|
Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to issue a pull request again. There's a problem in text rendering. Char under cursor was rendered with inverted color but in vertical line/underline mode it should be rendered with just normal color.