Skip to content

Commit

Permalink
definitive fix
Browse files Browse the repository at this point in the history
  • Loading branch information
garak committed Nov 3, 2024
1 parent 88b2beb commit f8a90a0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 19 deletions.
7 changes: 0 additions & 7 deletions tests/Metadata/Driver/AttributeReaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@

final class AttributeReaderTest extends TestCase
{
protected function setUp(): void
{
if (\PHP_VERSION_ID < 80000) {
self::markTestSkipped('Tests for PHP 8 only');
}
}

public function testGetClassAnnotations(): void
{
$reader = new AttributeReader();
Expand Down
14 changes: 2 additions & 12 deletions tests/VichUploaderBundleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,15 @@
*/
final class VichUploaderBundleTest extends TestCase
{
private static function checkKernel(): void
protected function setUp(): void
{
if (SimpleAppKernel::VERSION_ID >= 72000) { // @phpstan-ignore-line
if (SimpleAppKernel::VERSION_ID >= 70200) { // @phpstan-ignore-line
self::markTestSkipped('Kernels above 7.1.0 are not supported in these tests');
}
}

public function testSimpleKernel(): void
{
self::checkKernel();

$kernel = new SimpleAppKernel('test', true);
$kernel->boot();

Expand All @@ -38,8 +36,6 @@ public function testSimpleKernel(): void

public function testFilesystemKernel(): void
{
self::checkKernel();

$kernel = new FilesystemAppKernel('test', true);
$kernel->boot();

Expand All @@ -49,8 +45,6 @@ public function testFilesystemKernel(): void

public function testFlysystemOfficialKernel(): void
{
self::checkKernel();

$kernel = new FlysystemOfficialAppKernel('test', true);
$kernel->boot();

Expand Down Expand Up @@ -101,8 +95,6 @@ public function testFlysystemOfficialKernel(): void

public function testFlysystemOneUpKernel(): void
{
self::checkKernel();

if (!\class_exists(OneupFlysystemBundle::class)) {
self::markTestSkipped('OneupFlysystemBundle not installed');
}
Expand Down Expand Up @@ -157,8 +149,6 @@ public function testFlysystemOneUpKernel(): void

public function testReplacingFileIsCorrectlyUploaded(): void
{
self::checkKernel();

$kernel = new FlysystemOfficialAppKernel('test', true);
$kernel->boot();

Expand Down

0 comments on commit f8a90a0

Please sign in to comment.