Skip to content

Commit

Permalink
Increased default timeout in APIServer to 2 minutes
Browse files Browse the repository at this point in the history
This should for kubernetes#5431
  • Loading branch information
piosz committed Mar 14, 2015
1 parent 5326bae commit ffcf7b1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pkg/apiserver/apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ func parseTimeout(str string) time.Duration {
}
glog.Errorf("Failed to parse %q: %v", str, err)
}
return 30 * time.Second
// TODO: change back to 30s once #5180 is fixed
return 2 * time.Minute
}

func readBody(req *http.Request) ([]byte, error) {
Expand Down
4 changes: 2 additions & 2 deletions pkg/apiserver/apiserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1216,10 +1216,10 @@ func TestUpdateChecksDecode(t *testing.T) {
}

func TestParseTimeout(t *testing.T) {
if d := parseTimeout(""); d != 30*time.Second {
if d := parseTimeout(""); d != 2*time.Minute {
t.Errorf("blank timeout produces %v", d)
}
if d := parseTimeout("not a timeout"); d != 30*time.Second {
if d := parseTimeout("not a timeout"); d != 2*time.Minute {
t.Errorf("bad timeout produces %v", d)
}
if d := parseTimeout("10s"); d != 10*time.Second {
Expand Down

0 comments on commit ffcf7b1

Please sign in to comment.