Skip to content

Commit

Permalink
The quotes around the file should not be necessary
Browse files Browse the repository at this point in the history
In Go 1.2 on the Mac they result in a file created with actual
quotes.
  • Loading branch information
smarterclayton committed Jul 25, 2014
1 parent fbd71c9 commit f794801
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions build/build-image/run-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ cd "${KUBE_TARGET}"
echo "+++ Running unit tests"

if [[ -n "$1" ]]; then
go test -cover -coverprofile="tmp.out" "$KUBE_GO_PACKAGE/$1"
go test -cover -coverprofile=tmp.out "$KUBE_GO_PACKAGE/$1"
exit 0
fi

for package in $(find_test_dirs); do
go test -cover -coverprofile="tmp.out" "${KUBE_GO_PACKAGE}/${package}"
go test -cover -coverprofile=tmp.out "${KUBE_GO_PACKAGE}/${package}"
done
2 changes: 1 addition & 1 deletion hack/test-go.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ find_test_dirs() {
}

# -covermode=atomic becomes default with -race in Go >=1.3
KUBE_COVER="-cover -covermode=atomic -coverprofile=\"tmp.out\""
KUBE_COVER="-cover -covermode=atomic -coverprofile=tmp.out"

cd "${KUBE_TARGET}"

Expand Down

0 comments on commit f794801

Please sign in to comment.