Skip to content

Commit

Permalink
Switch official builds to go 1.4.
Browse files Browse the repository at this point in the history
This fixes kubernetes#2894
  • Loading branch information
jbeda committed Jan 21, 2015
1 parent 903de0c commit a735e2d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion build/build-image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ ENV GOOS linux
ENV GOARCH amd64

# Get the code coverage tool and godep
RUN go get code.google.com/p/go.tools/cmd/cover github.com/tools/godep
RUN go get golang.org/x/tools/cmd/cover github.com/tools/godep

# We use rsync to copy some binaries around. It is faster (0.3s vs. 1.1s) on my
# machine vs. `install`
Expand Down
2 changes: 1 addition & 1 deletion build/build-image/cross/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# This file creates a standard build environment for building cross
# platform go binary for the architecture kubernetes cares about.

FROM golang:1.3
FROM golang:1.4
MAINTAINER Joe Beda <jbeda@google.com>

ENV KUBE_CROSSPLATFORMS \
Expand Down
4 changes: 2 additions & 2 deletions build/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ readonly KUBE_BUILD_IMAGE_REPO=kube-build
# KUBE_BUILD_CONTAINER_NAME=kube-build-<hash>
readonly KUBE_BUILD_IMAGE_CROSS_TAG=cross
readonly KUBE_BUILD_IMAGE_CROSS="${KUBE_BUILD_IMAGE_REPO}:${KUBE_BUILD_IMAGE_CROSS_TAG}"
readonly KUBE_BUILD_GOLANG_VERSION=1.3
readonly KUBE_BUILD_GOLANG_VERSION=1.4
# KUBE_BUILD_DATA_CONTAINER_NAME=kube-build-data-<hash>

# Here we map the output directories across both the local and remote _output
Expand Down Expand Up @@ -261,7 +261,7 @@ function kube::build::build_image_built() {
}

function kube::build::ensure_golang() {
kube::build::docker_image_exists golang 1.3 || {
kube::build::docker_image_exists golang "${KUBE_BUILD_GOLANG_VERSION}" || {
[[ ${KUBE_SKIP_CONFIRMATIONS} =~ ^[yY]$ ]] || {
echo "You don't have a local copy of the golang docker image. This image is 450MB."
read -p "Download it now? [y/n] " -r
Expand Down

0 comments on commit a735e2d

Please sign in to comment.