kubelet_test: Fix copy bug.

Initialize the slice before copying in verifyUnorderedCalls() and verifyStringArrayEqualsAnyOrder().
duda · Mar 31, 2015 · 7b1ea6b · 7b1ea6b
1 parent acd67eb
commit 7b1ea6b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/pkg/kubelet/dockertools/fake_docker_client.go b/pkg/kubelet/dockertools/fake_docker_client.go
@@ -71,7 +71,8 @@ func (f *FakeDockerClient) AssertUnorderedCalls(calls []string) (err error) {
 	f.Lock()
 	defer f.Unlock()
 
-	var actual, expected []string
+	actual := make([]string, len(calls))
+	expected := make([]string, len(f.called))
 	copy(actual, calls)
 	copy(expected, f.called)
 

diff --git a/pkg/kubelet/kubelet_test.go b/pkg/kubelet/kubelet_test.go
@@ -144,7 +144,8 @@ func verifyStringArrayEquals(t *testing.T, actual, expected []string) {
 }
 
 func verifyStringArrayEqualsAnyOrder(t *testing.T, actual, expected []string) {
-	var act, exp []string
+	act := make([]string, len(actual))
+	exp := make([]string, len(expected))
 	copy(act, actual)
 	copy(exp, expected)