Skip to content

Commit

Permalink
test-cmd.sh can fail if public IP not available
Browse files Browse the repository at this point in the history
test-cmd runs a 127.0.0.1 version of the apiservers, but does not
set --public_address_override, which means it can fail on some systems
(like Macs) which don't expose a bindable external port by default.

Since reachability is not necessary for test-cmd.sh today, set
public_address_override to 127.0.0.1
  • Loading branch information
smarterclayton committed Nov 1, 2014
1 parent 10de0d1 commit 6e1527e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions hack/test-cmd.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ wait_for_url "http://127.0.0.1:${KUBELET_PORT}/healthz" "kubelet: "
# Start apiserver
${GO_OUT}/apiserver \
--address="127.0.0.1" \
--public_address_override="127.0.0.1" \
--port="${API_PORT}" \
--etcd_servers="http://${ETCD_HOST}:${ETCD_PORT}" \
--kubelet_port=${KUBELET_PORT} \
Expand Down

0 comments on commit 6e1527e

Please sign in to comment.